Trailing comma in metadata.json

khagaroth · February 5, 2023, 10:17am

There is a trailing comma in usr/share/wallpapers/EndeavourOS/metadata.json resulting in JSON parse error. Please note that even though trailing commas are allowed and even encouraged in plain javascript, they are not allowed in JSON.

joekamprad · February 5, 2023, 10:35am

is this with GNOME?

joekamprad · February 5, 2023, 10:40am

not sure where this file should came from…
we only have this:

github.com

endeavouros-team/PKGBUILDS/blob/master/eos-settings-gnome/endeavouros.xml

<?xml version="1.0"?>
<!DOCTYPE wallpapers SYSTEM "gnome-wp-list.dtd">
<wallpapers>
  <wallpaper deleted="false">
    <name>endeavouros</name>
    <filename>/usr/share/endeavouros/backgrounds/endeavouros-wallpaper.png</filename>
    <filename-dark>/usr/share/endeavouros/backgrounds/endeavouros-wallpaper.png</filename-dark>
    <options>zoom</options>
    <shade_type>solid</shade_type>
    <pcolor>#46226e</pcolor>
    <scolor>#000000</scolor>
  </wallpaper>
</wallpapers>

but usr/share/wallpapers/EndeavourOS is not used afaik…
So some script or app must have created this… could be Gnome but I am not aware of any…

khagaroth · February 5, 2023, 11:02am

github.com

endeavouros-team/eos-settings-plasma/blob/8cb63ad8233f65e7b63b39afe89ebb72a83894e8/usr/share/wallpapers/EndeavourOS/metadata.json

{
    "KPlugin": {
        "Id": "EndeavourOS",
        "License": "CC-BY-SA-4.0",
        "Name": "EndeavourOS",
    }
}

joekamprad · February 5, 2023, 2:12pm

okay not GNOME and KDE instead…
Not sure i see where this is an issue or what exactly it is causing?
but see:

https://github.com/endeavouros-team/eos-settings-plasma/commit/73f6ff61a1fcfe9f15f5ef311f0509ba0e8f0c41

its changed already

dalto · February 5, 2023, 2:15pm

Thanks for reporting it.

It has been fixed and the PKGBUILD has been updated and pushed. Once the package is built it will be available in the repos.

khagaroth · February 5, 2023, 2:35pm

I noticed it throwing a warning when browsing through the journal looking at some ACPI related errors I was seeing at boot.

joekamprad · February 5, 2023, 2:44pm

yes indeed thank’s for the report this is how things get fixed fast