Reflector-simple inprovement

manuel

Hi, I want to add some changes to reflector-simple.
I think it would be great improvement to not only select user country but also countries directly close to it, automatically.
But I think for me is easiest way to do it is by introducing small python helper that would by called from reflector-simple bash script.
Do you think it is good Idea? Or I should look for a way to implement everything in bash?

That idea is something that I thought of too when I created reflector-simple.
But the thing is there are many locations where users do not want to automatically include neighbor countries to the list. And in many cases users already know which countries to select.

That’s why I’m a bit hesitant about the feature.

But if you still want to implement it, let me know.
The feature should be at least configurable e.g. via the config file,
and better do it as you suggested as a separate app.
Then reflector-simple could execute the app and read its output normally from stdin.

I am hesitant about this feature too. Not at all times it is the best choice.
An example: in Germany you would opt for german mirrors and add some other countries automatically. You might get a german mirror on top of the list. If you have the wrong internet provider you may stuck with the problem, that downloads from those mirrors are really slow even they are fast while searching them from reflector-simple.
I found out that all german mirrors are really slow with Vodafone as internet provider. Changing the mirrors to a different european country (I don’t disclose which one it is) gives you the maximum speed your line can provide.
Changing the normal behaviour would make it more difficult. If you want to implement that feature please make it configurable and disabled by default.

Ok. Got it.
I still want to do it, I think it will be useful. Also, some people do not want their country of location mirrors :sweat_smile:

Does this repo is right place to send pull request?

That’s the one.
But please take your time, no hurry. And I’m rather busy for a couple of next weeks.

1 Like

I have also some proposal to defaults change to tackle this problem :blush:

Pur pur? Hope you will have some time soon :blush:

Yeah, I haven’t forgotten this. I think the idea is worth adding in some way or another, considering all aspects related to the matter.

But currently I’m really busy, so it will take some time.

Ok. PR is on github. So look when you will have time :heart: