@ricklinux I’m guessing that @mbod is referring to kernel live patching (which can be done with a tool called kpatch in the AUR) though I could be wrong.
* [PATCH] pinctrl: amd: Don't show `Invalid config param` errors
@ 2023-07-17 20:16 Mario Limonciello
2023-07-23 19:41 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2023-07-17 20:16 UTC (permalink / raw)
To: linus.walleij
Cc: Basavaraj.Natikar, Shyam-sundar.S-k, linux-gpio, linux-kernel,
mario.limonciello
On some systems amd_pinconf_set() is called with parameters
0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
which are not supported by pinctrl-amd.
Don't show an err message when called with an invalid parameter,
downgrade this to debug instead.
Cc: stable@vger.kernel.org # 6.1
Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/pinctrl/pinctrl-amd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 4a8c1b57a90d6..20bd97a603d9c 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -748,7 +748,7 @@ static int amd_pinconf_get(struct pinctrl_dev *pctldev,
break;
default:
- dev_err(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
+ dev_dbg(&gpio_dev->pdev->dev, "Invalid config param %04x\n",
param);
return -ENOTSUPP;
}
@@ -798,7 +798,7 @@ static int amd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
break;
default:
- dev_err(&gpio_dev->pdev->dev,
+ dev_dbg(&gpio_dev->pdev->dev,
"Invalid config param %04x\n", param);
ret = -ENOTSUPP;
}
--
2.34.1
It is basically the email from the LKML.
I am using the linux-tkg kernel as my default kernel: https://github.com/Frogging-Family/linux-tkg
And the linux-tkg kernel build process provides an option to apply user patches. That’s it. Very simple. Very convenient.
By the way: Why do I use the linux-tkg kernel? I like the zen kernel. Specifically the changes it does to the CFS scheduler. But there is no zen kernel for the linux-lts branch. Here comes the linux-tkg kernel. It provides “zenify” patches for linux-lts.
These are nothing new with this GPU but lately they have been happening more frequently than usual.
In this case failing “process” is Picom but it happens also without compositor and then culprit can be almost any active process. This is only a wild guess after last 2-3 Firefox versions I’ve had lots of more these crashes.
Yeah could be vram or anything, It is really hard to debug My brother has RX6700 and he has lot’s of hard reset even on windblows. The only positive thing is that these resets never happen while gaming, no matter how demanding it is.
UEFI it is latest and greatest. If I remember correctly those errors started soon after kernel 5.19, before that it was stable. Also in Gitlab there are hundreds of posts about same kind of problems with 6600-series cards.
Possibly it’s probably firmware/kernel related. On my RX 590 all of dmesg is pristine and same with journalctl. I only have a couple of Kde related messages in the journal.
My brother has RX6700 and he has lot’s of hard reset even on windblows. The only positive thing is that these resets never happen while gaming, no matter how demanding it is.