How to apply a patch

General system
21

Seems like it was the case. I copied the one posted on AUR (with diff and everything) and it seems patched. Will try to build it.

1 Like
22

Where did you put the PKGBUILD and the patch? Was it a completely empty folder/directory?

23

I created a new folder next to the original one and started with just PKGBUILD and p.txt.
This is what it looks like now:

thomas at hermes in ~/.cache/yay/test
$ ll
total 751M
d--x--x--x 1 thomas users    0 Mai  2 20:05 pkg
drwxr-xr-x 1 thomas users  546 Mai  2 20:05 src
-rw-r--r-- 1 thomas users  23K Mai  2 20:03 54bc225e3a263be9a6b7dc5a33c5d713d9c42716.tar.gz
-rw-r--r-- 1 thomas users 663K Mai  2 20:03 81.0.4044.129-1.tar.gz
-rw-r--r-- 1 thomas users 750M Mai  2 20:03 chromium-81.0.4044.129.tar.xz
-rw-r--r-- 1 thomas users 5,0K Mai  2 20:03 chromium-launcher-6.tar.gz
-rw-r--r-- 1 thomas users 7,6K Mai  2 19:22 PKGBUILD
-rw-r--r-- 1 thomas users 5,9K Mai  2 19:21 p.txt

thomas at hermes in ~/.cache/yay/test
24

The fact that you instantly got to [38147/38522] leads me to believe it is not clean built which is odd if it was an empty directory.

Try makpkg -Ci, make sure you are in the test directory and not the ungoogled-chromium directory. That should force a clean build.

25

Didn’t work I am afraid. Same error…

26

What does this output:

grep BUILDDIR /etc/makepkg.conf
27 
grep BUILDDIR /etc/makepkg.conf
#BUILDDIR=/tmp/makepkg
28

I am not sure, have you tried rebooting and running makepkg -Ci again?

It doesn’t seem to be a patch issue, it seems to be keeping a cache of your build somewhere.

29

I did reboot now, didn’t change things I am afraid. The compiler whizzes through the files and stops with the same error.
Looks like my machine is able to munch through this package, or at least to the point where things stop, in ~10 minutes. Not sure why it took hours previously. Maybe a warmer system when docked which leads to CPUs getting throttled? Something else to look into.

But let’s not waste more of your time with this, as of today a new version of the package is available which will surely address this issue.

Nevertheless you helped me a great deal in understanding the moving parts. Maybe I’ll pick up this thread again once the next patch needs to be applied.
Thanks for your help @dalto

Edit: Didn’t want to give up just now and tried again, this time I re-added the header section back in:

diff -rupN a/v8/src/objects/js-number-format.cc b/v8/src/objects/js-number-format.cc
--- a/v8/src/objects/js-number-format.cc    2020-04-27 21:39:11.000000000 -0400
+++ b/v8/src/objects/js-number-format.cc    2020-05-01 16:50:48.402713000 -0400
@@ -1197,42 +1197,31 @@ MaybeHandle<JSNumberFormat> JSNumberForm
 }

…and guess what, my machine whizzed through in less than 10 minutes and successfully created the app. Leaves the question why this took hours last time?

@Tasia91, I guess this confirms that this header is indeed part of the patch.

Again, @dalto, thanks for your help, learned a great deal!

3 Likes