Bug inside Forum (discourse) norway flag missing

joekamprad · December 28, 2019, 11:53pm

do you set your nationality flag ? or you have had it enabled and changing it to no flag? as there is may a bug inside forum software i see this: Bildschirmfoto_2019-12-29_00-53-24

gummybear · December 28, 2019, 11:55pm

A bug yes!

joekamprad · December 28, 2019, 11:59pm

do you want to show your flag?

gummybear · December 29, 2019, 12:01am

Yes! Set my flag in my preferences.

joekamprad · December 29, 2019, 12:04am

seems norway is broken
@Bryanpwo ?

![Bildschirmfoto_2019-12-29_01-03-51|351x286](upload://lxOCZG3Rs1zl2ClCtgSUPfJ1sL1.png
should be this:
https://forum.endeavouros.com/plugins/discourse-nationalflags/images/nationalflags/no.png

but setting it to this:
https://forum.endeavouros.com/plugins/discourse-nationalflags/images/nationalflags/false.png

ha ha norway should be NOR but file is named “no.png” so it sets flag to no!

gummybear · December 29, 2019, 12:05am

LOL yes right

joekamprad · December 29, 2019, 12:25am

github.com

Ebsy/discourse-nationalflags/blob/4032e3bcc999f91d062dbf67f1313f0bdf5bcf24/config/locales/client.en.yml#L179


      
          mw: Malawi
          mx: Mexico
          my: Malaysia
          mz: Mozambique
          na: Namibia
          nc: "New Caledonia"
          ne: Niger
          nf: "Norfolk Island"
          ng: Nigeria
          ni: Nicaragua
          nl: Netherlands
          none: "No flag"
          np: Nepal
          nr: Nauru
          nu: Niue
          nz: "New Zealand"
          om: Oman
          pa: Panama
          pe: Peru
          pf: "French Polynesia"
          pg: "Papua New Guinea"

simple missing the link to the flag in the plugin … BUG solved lets hope they will merge the fix soon

Bryanpwo · December 30, 2019, 10:49am

From now on the Norwegian flag is proudly represented in our United Endeavour world

joekamprad · December 30, 2019, 11:07am

Bildschirmfoto_2019-12-30_12-06-39
not jet ready?

Bryanpwo · December 30, 2019, 11:22am

Hmm, I assumed it was fixed because it was mentioned in today’s update, it looks like the picture is broken. Well I’ll report it then.

joekamprad · December 30, 2019, 11:25am

it still links to false.png what is not the right it should link to no.png but may a cache issue? is discourse getting “plugins” directly from GitHub or from somewhere else?

Bryanpwo · December 30, 2019, 11:30am

From Github but to be fair I perform the daily updates and not the big stack updates they send notifications for. This is like installing Arch-testing repo, I assumed this issue wasn’t a big one that’s why I did mention it. Normally I don’t do that.

eljejer · March 31, 2020, 7:48pm

Norwegian flag still missing guys…

joekamprad · September 11, 2020, 8:48am